Skip to content

Remove Nooria From Civic-Tech-Jobs #8245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mugdhchauhan merged 1 commit into from
Jul 11, 2025
Merged

Remove Nooria From Civic-Tech-Jobs #8245

mugdhchauhan merged 1 commit into from
Jul 11, 2025

Conversation

@valdezg
Copy link
Member

@valdezg valdezg commented Jul 8, 2025 •
edited
Loading

Fixes #8070

What changes did you make?

  • Made these changes to remove Nooria's information from Civic-Tech-Jobs

Why did you make the changes (we will use this info to test)?

  • Keep project information up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2025-05-17 221119

Visuals after changes are applied

Screenshot 2025-05-17 221140

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b valdezg-remove-nooria-civic-jobs-8070 gh-pages
git pull https://github.com/valdezg/website.git remove-nooria-civic-jobs-8070

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 8, 2025
@valdezg valdezg changed the title remove nooria from civic-tech-jobs Remove Nooria From Civic-Tech-Jobs Jul 9, 2025
@katiejnete katiejnete self-requested a review July 9, 2025 04:47
@katiejnete
Copy link
Member

katiejnete commented Jul 9, 2025

Availability: Varying weekdays, after 7PM
ETA: EOD

katiejnete
katiejnete approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @valdezg , thank you for taking on this issue.

Things you did well:

PR is done with the correct branch.
PR contains correctly formatted linked issue.
CodeQL Alerts have been properly checked.
Before and after screenshots are appropriately included.
PR follows correct format and is properly written.
The changes are applicable to the issue.
Website is still user-friendly and links and components still work as intended.
Source code changes are applicable.

Suggested changes:

None

Thank you for your hard work, I approve this PR.

@caz002 caz002 self-requested a review July 10, 2025 06:17
@caz002
Copy link
Member

caz002 commented Jul 10, 2025

Availability: M-F after 2pm
ETA: 7/10/25

caz002
caz002 approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for working on this issue @valdezg !

Things Done well

  • Only the file requested in the issue is modified, and website still works as expected
  • Code does not trigger Code QL alerts
  • Description and visuals accurately describe changes

The pull request and branch looks good, and I have no requested changes. Thank you for your hard work!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Jul 11, 2025
@mugdhchauhan
Copy link
Member

mugdhchauhan commented Jul 11, 2025

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉

@mugdhchauhan mugdhchauhan merged commit 77edbec into hackforla:gh-pages Jul 11, 2025
17 checks passed
@caz002 caz002 mentioned this pull request Jul 11, 2025
Open
@mugdhchauhan mugdhchauhan mentioned this pull request Jul 15, 2025
Closed
This was referenced Aug 10, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caz002 caz002 caz002 approved these changes

+1 more reviewer

@katiejnete katiejnete katiejnete approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

P: HfLA Website: Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs - Remove Nooria Ali

4 participants

@valdezg @katiejnete @caz002 @mugdhchauhan